oneOf not validating correctly?

The oneOf middleware appears to be validating incorrectly.

The below validates successfully

// body
{
    "myField": true
}

// validation middleware
oneOf([check('myField').isString()])

This test case looks wrong, shouldn’t it be something other than isBoolean()?

https://github.com/express-validator/express-validator/blob/7ba714b26d802547369615c90e74389c1b9c83a0/src/middlewares/one-of.spec.ts#L176-L186

[fedeci]

This works as intended:

const { oneOf, body, validationResult } = require('express-validator')
const express = require('express')

const app = express()
app.use(express.json())

app.post('/', oneOf([body('boolean').isString()]), (req, res, next) => {
  console.warn(validationResult(req))
})

app.listen(3000)

[7opf]

Right, I wasn’t using validationResult in my middleware 🤦

export function validateOneOf(schemas: Schema[]): express.RequestHandler {
    const validationChainsList = schemas.map(s => checkSchema(s));
    const middleware = oneOf(validationChainsList);
    return async (req: express.Request, res: express.Response, next: express.NextFunction) => {
        await middleware.run(req);
        const errors = validationResult(req);

        if (errors.isEmpty()) {
            return next();
        }

        next(new HttpError({
            status: StatusCodes.BAD_REQUEST,
            message: 'Invalid request',
            extra: errors.mapped()
        }));
    };
}