Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Should .exists() check for null values as well?

See original GitHub issue

Currently the .exists() validator only checks for undefined, does it make sense to add an option to also check for null? Something like: check('id').exists({ checkFalsy: true }) //or check('id').exists({ checkNull: true })

or should we be using a different validator like notEmpty() or not().optional() ?

Thanks so much for your help.

Issue Analytics

State:
Created 6 years ago
Reactions:2
Comments:6 (4 by maintainers)

Top GitHub Comments

1reaction

gustavohenkecommented, Apr 30, 2018

@sant123 false or 0 would succeed when check with .not().isEmpty(), as it will only check the string representation of the value has something in it (null and undefined are both represented as an empty string).

A checkFalsy option for exists would work differently, failing the validation if the value is falsy.

0reactions

lock[bot]commented, May 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.