Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Session save does not support a callback url

See original GitHub issue

Cookie session does not implement the documented interface for express session save. As you can see here : https://github.com/expressjs/session/blob/8e57b21bef0d53010c4d37f4beee3f0341f3eaa6/session/session.js#L71

and per the documentation here: https://github.com/expressjs/session#sessionsavecallback

Save should take an optional callback method. The background is i’m trying to implement this fix: https://github.com/jaredhanson/passport/issues/482#issuecomment-230594566 But I can’t since there is no callback url

Issue Analytics

State:
Created 6 years ago
Comments:6 (5 by maintainers)

Top GitHub Comments

1reaction

dougwilsoncommented, Sep 25, 2018

It probably doesn’t matter at this point, as the 1.x series is about to be deprecated with the release of 2.0.

0reactions

dougwilsoncommented, Jan 6, 2020

Sorry I didn’t get to doing this. No PR came up either, and as I was about to do this, I noticed that save was never a documented method and the JSDoc marks it as a private API, so probably best just to actually remove the ability for users to call it at all from 2.0 to prevent confusion. Calling .save() just generates a cookie value and is a sync action, so has no purpose in this module.