404 With Multiple Images in One Request

I’m receiving a 404 Not Found error when I attempt to submit a form that has two images uploaded. Neither image is a required field, so when I upload one image (can be either) everything works correctly, and I do not get an error. The issue only occurs when I upload both in one request. Checking my uploads folder, when I get a 404, both images are correctly uploaded. Here is the code for multer and resizing:

const multerOptions = {
  storage: multer.memoryStorage(),
  fileFilter(req, file, next) {
    const isPhoto = file.mimetype.startsWith('image/');
    if (isPhoto) {
      next(null, true);
    } else {
      next({ message: 'That filetype isn\'t allowed!' }, false);
    }
  },
};

export const upload = multer(multerOptions).fields([
  { name: 'avatar' },
  { name: 'accolade' },
]);

export const resize = async (req, res, next) => {
  if (!req.files) {
    next();
    return;
  }
  Object.keys(req.files).forEach(async (file) => {
    const extension = req.files[file][0].mimetype.split('/')[1];
    req.body[file] = `${uuid.v4()}.${extension}`;
    const uploaded = await jimp.read(req.files[file][0].buffer);
    if (file === 'avatar') {
      await uploaded.resize(300, jimp.AUTO);
    } else if (file === 'accolade') {
      await uploaded.resize(30, jimp.AUTO);
    }
    await uploaded.write(`./public/uploads/${req.body[file]}`);
    next();
  });
};

I’m passing both functions to this route:

router.post(
  '/team-members/add/:id',
  authController.authCheck,
  userController.isAdmin,
  userController.upload,
  userController.resize,
  userController.validateUser,
  catchErrors(userController.addTeamMember),
);

The final method, addTeamMember fires correctly and the user is added, but I get a 404 not found and Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client. Any ideas?

[joshloftis]

Ugh. I found it. I included next() inside the forEach block in the resize method on accident. Moved it outside and everything works. Thanks!

[joshloftis]

Thanks again for responding!

I added the return statement, but unfortunately still getting the error when uploading two images at the same time.

I’ve added a question at SO, and will close this issue as it seems it probably isn’t an issue with this package from your responses. https://stackoverflow.com/questions/49982952/nodejs-multer-receiving-404-and-cannot-set-headers-when-uploading-multiple-fil