Crash on .single

Hi. When using the .single function to specify that only one upload is allowed, you can make the app crash by uploading two files at the same time. The error is as follows:

fs.js:932
  binding.unlink(pathModule._makeLong(path), req);
          ^

TypeError: path must be a string
    at TypeError (native)
    at Object.fs.unlink (fs.js:932:11)
    at DiskStorage._removeFile (node_modules/multer/storage/disk.js:61:6)
    at remove (node_modules/multer/lib/make-middleware.js:64:19)
    at handleFile (node_modules/multer/lib/remove-uploaded-files.js:10:5)
    at removeUploadedFiles (node_modules/multer/lib/remove-uploaded-files.js:25:3)
    at EventEmitter.<anonymous> (node_modules/multer/lib/make-middleware.js:67:9)
    at EventEmitter.g (events.js:260:16)
    at emitNone (events.js:72:20)
    at EventEmitter.emit (events.js:166:7)
    at EventEmitter.decrement (node_modules/multer/lib/counter.js:15:32)
    at node_modules/multer/lib/make-middleware.js:146:34
    at WriteStream.<anonymous> (node_modules/multer/storage/disk.js:43:9)
    at emitNone (events.js:72:20)
    at WriteStream.emit (events.js:166:7)
    at finishMaybe (_stream_writable.js:468:14)

Thanks!

[ohmyhusky]

I’ve got the same error and I’ve found 2 ways to reproduce the error, both using .array('files', 3):

1. if you don’t write some limits like fileSize or something like that, just multer({ dest : 'uploads' }), then you can reproduce the error by upload more than 3 files with at least 2 mime types (at least have one file which has different type with others).
2. if you write some limits like limits:{fileSize:1048576}, then you can reproduce the error by upload more than 3 files with at least 1 file break the fileSize rule (in fact it break two rules), even all of then are the same type, you can still get this error.

I didn’t dig much into this. Sometimes it’s very wired the code works well if you upload 4 files to it(LIMIT_UNEXPECTED_FILE error will be catch by express error handler), but if you upload 5 files, then you will get this error and the program crashed.

If you output the file before fs.unlink(path, cb), there’s no ‘path’ property, I guess because it didn’t success to upload? path ? fs.unlink(path, cb) : cb() can avoid unlink undefined path, but I don’t know if there’s something more need to be done.

node: 5.9.0

“dependencies”: { “express”: “^4.13.4”, “multer”: “^1.1.0” }

OS X 10.11.3

Chrome 49

var express = require( 'express' ); var multer = require( 'multer' ); var fs = require( 'fs' ); var app = express(); var upload = multer( { dest : 'uploads', limits : { fileSize : 1048576 } } );

app.get( '/', ( req, res ) => fs.createReadStream( 'index.html' ).pipe( res ) );

app.post( '/files', upload.array( 'files', 3 ), ( req, res ) => res.end( 'uploaded' ) );

app.use( ( err, req, res, next ) => res.end( err.code + '\n' + err.stack ) );

app.listen( 8888 );

<form action="/files" method="post" enctype="multipart/form-data"> <input type="file" name="files" multiple> <input type="submit"> </form>

[JonathanOkz]

Hi, I had the same error with multer@1.1.0 :

fs.js:975
  binding.unlink(pathModule._makeLong(path), req);
          ^

TypeError: path must be a string
    at TypeError (native)
    at Object.fs.unlink (fs.js:975:11)
    at DiskStorage._removeFile (/home/server/server/node_modules/multer/storage/disk.js:61:6)
    at remove (/home/server/server/node_modules/multer/lib/make-middleware.js:64:19)
    at handleFile (/home/server/server/node_modules/multer/lib/remove-uploaded-files.js:10:5)
    at removeUploadedFiles (/home/server/server/node_modules/multer/lib/remove-uploaded-files.js:25:3)
    at EventEmitter.<anonymous> (/home/server/server/node_modules/multer/lib/make-middleware.js:67:9)
    at EventEmitter.g (events.js:260:16)
    at emitNone (events.js:72:20)
    at EventEmitter.emit (events.js:166:7)
    at EventEmitter.decrement (/home/server/server/node_modules/multer/lib/counter.js:15:32)
    at /home/server/server/node_modules/multer/lib/make-middleware.js:146:34
    at WriteStream.<anonymous> (/home/server/server/node_modules/multer/storage/disk.js:43:9)
    at emitNone (events.js:72:20)
    at WriteStream.emit (events.js:166:7)
    at finishMaybe (_stream_writable.js:468:14)

I added : if (path) fs.unlink(path, cb) in /multer/storage/disk.js +61 as suggested @nickmitsh and the bug seems fixed

This is the good way to fix this issue ?