File still uploads even when it exceeds fileSize limit

For testing purposes, I’m uploading a 102kB file with limits setup like so:

...
const limits = {
    fileSize: 5,
};

const upload = multer({storage: storage, fileFilter: fileFilter, limits: limits});
...

Clearly that exceeds the 5 byte limit, but I’m finding that the file still gets saved without any errors, except that the saved file is 5 bytes in size, so it seems something just writes the first part of the file and then gives up. I’m assuming this isn’t an intended feature, but do correct me if I’m wrong.

[adf0001]

Hmm, it seems like this test case should cover that, and it passes

https://github.com/expressjs/multer/blob/master/test/issue-232.js

Would you be able to submit a failing test case? Then I can take a look at fixing it

line changed: form.append(‘file’, util.file(‘huge.rar’)) //huge.rar is a file of 2600M (2.6G)

mocha --timeout 120000 issue-232.js

Issue #232 √ should report limit errors (24565ms)

1 passing (25s) //<------ too long

When I test in Chrome locally, I get 0% to 100% uploading status report from Chrome, and at 100%, get a “MulterError: File too large”. The error emit after all the file has uploaded.

windows 7, node v6.5, multer 1.4.1

[munawarb]

Hi @FINDarkside, You’re welcome 😃. Last I tested which was a couple months ago with Firefox, it timed out when Formidable closed the connection on a large file upload. So yup it looks like browsers are still not following the spec. Here’s some Formidable middleware for Express that works well for me. It’s better than using express-formidable because you get more control by implementing it yourself:

// This middleware will add body to the request object and files will be contained in the files field.
// The upload directory is also defined here.
app.use((req, res, next) => {
	const form = new formidable.IncomingForm({keepExtension: true, maxFileSize: 2.5*1024*1024, uploadDir: uploadDirectory});
	form.parse(req, (err, body, files) => {
		if (err)
			return next(err);
		Object.assign(req, {body, files});
		next();
	});
});