fileFilter not working

I wrote about this here https://github.com/expressjs/multer/issues/192

I have multer 1.0.6 , node 4.1.2, express 4.13.3

And this in file filter:

fileFilter: function (req, file, cb) {

        // The function should call `cb` with a boolean
        // to indicate if the file should be accepted

        // To reject this file pass `false`, like so:
        if (file.mimetype !== 'image/png'
            && file.mimetype !== 'image/jpg'
            && file.mimetype !== 'image/jpeg'
            && file.mimetype !== 'image/gif') {
            console.log('Got file of type', file.mimetype);
            return cb(new Error('Only image files are allowed!'));
        }

        // To accept the file pass `true`, like so:
        cb(null, true);

    }

When I send image file, everything works properly. But when I send something else like blabla.txt I expect error to return, but the request goes pending… in Chrome it says it is pending. After a couple of minutes I get response with net::ERR_EMPTY_RESPONSE.

I tried calling only

cb(new Error('Only image files are allowed!'));

without return statement, same issue.

[pguerrerox]

Hello, This was happening to me, this is how I fix it,

• From this response - Link to #186 I grabed this code, He used it to display a “FILE TO BIG” error.

app.use(function (err, req, res, next) {
  if (err.code === 'LIMIT_FILE_SIZE') {
    res.send({ result: 'fail', error: { code: 1001, message: 'File is too big' } })
    return 
  }
  // Handle any other errors
})

• Them I added the following code:

if(err){
  console.log(err);
  res.send({ error: 'YOUR MESSAGE TO BE DISPLAY' });
}

This help me process the error created if the fileFilter is false.

hope it helps.

[benbonnet]

@srkkhan you’ve added the same wrong hint there (https://github.com/expressjs/multer/issues/114), but it is not safe to test a file by its filename extension, it has to be done by its mime type. That said, @tim-montague last answer on #114 has no real effects on my side 😕. Some has changed and things needs to be done another way ?