multer (1.4.1) hangs on malformed POST data

Multer hangs on malformed POST data. To reproduce the problem just run this script against any multer enabled URL.

$ multer-hang.sh <any-multer-post-url>

The script uses a minimal real world payload produced by this IE bug.

[LinusU]

I agree with @gireeshpunathil assessment!

Basically we cannot really do anything else then waiting for the timeout if the client says “I’m going to send you 2000 bytes”, then only sends 100 bytes…

happy to reopen if more information surfaces!

[gireeshpunathil]

we (@HarshithaKP and I) did some further debugging on this and found the following:

• the server intercepts the request, and passes it onto to multer
• multer sets up the middleware function and delegate the control to busboy
• busboy reads the header, and establishes the necessary event handlers accordingly
• busboy pipes the request to itself. the intent is to continue reading the input (when it arrives), parse, and invoke associated handlers.

As the request is malformed (less data than it claimed), none of these preparations are used anytime - basically nothing happens.

• server goes on to listen for other requests
• client hangs, as it does not get response from server

the scenario will continue until one of the entity times out.

I see no issues here, other than the resources being held up at server for a duration that is longer than desired; but that is where the timeout tuning becomes important.

In short, my assessment is that things are working as designed; however, would love to hear from @wesleytodd or others. thanks!