Multiple file fails / corrupted image uploaded

Multer work great for single image, but fails for multiple file uploads.

Problems I am facing with multiple uploads:

1. Multer is configured to upload maximum of 6 photos, I get only 4 or 5 photos in my folder.
2. I got corrupted images in my folder

Corrupted Image 1

Corrupted Image 2

Original Image

Multer Config

const MulterStorage = multer.diskStorage({
  destination: async function (req, file, callback) {
    const uploadPath = `public/images/${req.userId}`;
    callback(null, uploadPath);
  },
  filename: async function (req, file, callback) {
    const fileExt = file.originalname.substring(file.originalname.lastIndexOf('.')).toLowerCase();
    callback(null, `${await RandomUtils.uuid()}${fileExt}`);
  }
});

const uploadProfilePhoto = multer({
  storage: MulterStorage,
  fileFilter: function (req, file, callback) {
    const fileName = file.originalname.toLowerCase();
    if (!fileName.match(/\.(jpg|jpeg|png)$/)) {
      callback(new Error('Only JPG, JPEG & PNG Image Formats are only allowed!'));
    }
    callback(null, true);
  },
  limits: { fileSize: 800 * 800 },
  preservePath: true
}).array('photo', 6);

[jonchurch]

I was able to reproduce this with the code you supplied and the original image you supplied.

Unfortunately I think your original image is corrupted. Even when uploading it as a single image, the saved image was corrupted:

Note: Idk why but github is coercing this image to a png when I upload it

When running the original image through ImageMagick’s identify tool to check if the image has any issues, per this Stack Overflow answer I got this output which seems to suggest the original image is corrupted:

identify: Corrupt JPEG data: premature end of data segment `bad_image.jpg' @ warning/jpeg.c/JPEGWarningHandler/398.
identify: Corrupt JPEG data: 1 extraneous bytes before marker 0xc4 `bad_image.jpg' @ warning/jpeg.c/JPEGWarningHandler/398.
identify: Inconsistent progression sequence for component 0 coefficient 0 `bad_image.jpg' @ warning/jpeg.c/JPEGWarningHandler/398.
identify: Inconsistent progression sequence for component 1 coefficient 0 `bad_image.jpg' @ warning/jpeg.c/JPEGWarningHandler/398.
identify: Inconsistent progression sequence for component 2 coefficient 0 `bad_image.jpg' @ warning/jpeg.c/JPEGWarningHandler/398.
identify: Corrupt JPEG data: bad Huffman code `bad_image.jpg' @ warning/jpeg.c/JPEGWarningHandler/398.
identify: Corrupt JPEG data: 5761 extraneous bytes before marker 0xda `bad_image.jpg' @ warning/jpeg.c/JPEGWarningHandler/398.
identify: Inconsistent progression sequence for component 0 coefficient 0 `bad_image.jpg' @ warning/jpeg.c/JPEGWarningHandler/398.
identify: Inconsistent progression sequence for component 1 coefficient 0 `bad_image.jpg' @ warning/jpeg.c/JPEGWarningHandler/398.
identify: Inconsistent progression sequence for component 2 coefficient 0 `bad_image.jpg' @ warning/jpeg.c/JPEGWarningHandler/398.
identify: Corrupt JPEG data: bad Huffman code `bad_image.jpg' @ warning/jpeg.c/JPEGWarningHandler/398.
identify: Corrupt JPEG data: bad Huffman code `bad_image.jpg' @ warning/jpeg.c/JPEGWarningHandler/398.
identify: Corrupt JPEG data: 8313 extraneous bytes before marker 0xd9 `bad_image.jpg' @ warning/jpeg.c/JPEGWarningHandler/398.

[ml170722d]

I know this issue is resolved, but I wanted to share my experience with this problem.

I’m not and expert, but from my testing it looks like multer isn’t handling async functions for filename and destination. I have had the same problem with corrupted files, but I was using async functions. When I turned them into regular function there was not problem and everything was working fine.