index.js - line 342 - why is it calling the 'createSession()' function on store?

I am implementing a custom session store (on Mongo), and I was getting an error about a createSession() function not being implemented. I further investigated and found out that this method was not implemented by the MemoryStore as well, but that it was implemented in the /session/store.js file.

Is that a mistake?

Why not just put req.session = new Session(req, sess); there instead? It makes much more sense…

[dresende]

The documentation (Readme) does not explain correctly in my opinion. It should not say the store must extend from an EventEmitter but from the require("express-session").Store. This way you only need to implement the methods as described in the docs (get, set and destroy). Otherwise createSession is needed (which means you need to create resetMaxAge, touch, save, … on req.session).

[caub]

But store#createSession is not listed in Readme, it’s rather store#set that plays this role https://github.com/expressjs/session#storesetsid-session-callback

edit: it’s supposed to set session in req object