question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

issecure function is not checking for x-arr-ssl

See original GitHub issue

In Windows Azure there is header x-arr-ssl for check whether it is https or not. https://github.com/expressjs/session/blob/master/index.js#L599-L626 In issecure function we need to check for that header too.

Reference: https://tomasz.janczuk.org/2013/12/secure-by-default-with-ssl-in-windows.html

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:5 (3 by maintainers)

github_iconTop GitHub Comments

2reactions
dougwilsoncommented, Jun 15, 2017

This module only looks at the header for backwards compatibility. The ideal method is to key off the req.secure boolean instead, so people can use whatever logic they desire. Adding that header in this module will cause issues, namely that almost no one will be blocking that header so users can forge the value.

0reactions
munir131commented, Jun 19, 2017

@dougwilson Sorry for late reply. I made changes somewhat like you suggested. Thanks for detailed reply. I think we can close this issue. Thanks again.

Read more comments on GitHub >

github_iconTop Results From Across the Web

How do I determine whether a page is secure via JavaScript?
I want to know if the page is being accessed via http or https using JavaScript. Is there some sort of isSecure() method,...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found