issecure function is not checking for x-arr-ssl
See original GitHub issueIn Windows Azure there is header x-arr-ssl
for check whether it is https or not.
https://github.com/expressjs/session/blob/master/index.js#L599-L626 In issecure
function we need to check for that header too.
Reference: https://tomasz.janczuk.org/2013/12/secure-by-default-with-ssl-in-windows.html
Issue Analytics
- State:
- Created 6 years ago
- Comments:5 (3 by maintainers)
Top Results From Across the Web
How do I determine whether a page is secure via JavaScript?
I want to know if the page is being accessed via http or https using JavaScript. Is there some sort of isSecure() method,...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
This module only looks at the header for backwards compatibility. The ideal method is to key off the req.secure boolean instead, so people can use whatever logic they desire. Adding that header in this module will cause issues, namely that almost no one will be blocking that header so users can forge the value.
@dougwilson Sorry for late reply. I made changes somewhat like you suggested. Thanks for detailed reply. I think we can close this issue. Thanks again.