saveUninitialized doesn't work with PassportJS

Sessions are always saved, even when saveUninitialized is set to false.

I’ve done a little bit of investigation, and I think I have identified the issue. Looks like it is in lines 420 - 429. When it hashes the “original session” it does so session without the id being set on it. So when it hashes it again at the end of the request the shouldSave returns true because the session now has the id set.

If this is indeed the problem, one approach might be replacing store.createSession(req, sess); with sess = store.createSession(req, sess);

[brendonparker]

I figured it out… Somehow was using an older version of passportjs (0.2.2). Updated to 0.3.2, which fixed this issue. The old version was adding an empty passport object to the session, which caused the dirty check to fail, and this created the session. Sorry for the false alarm and thanks for your help.

The moral of the story, for other who experience this problem in the future, is to make sure that you don’t have some middleware that is adding things to the req.session object unnecessarily.

[meetDeveloper]

@brendonparker Sir, Can I chat with you, I have few doubts about sessions that are troubling me.