Performace issue

Hi @Mike-EEE, I’m experiencing a performance issue when trying to serialize pretty complex object with few dozens of items with custom serializer in list. Currently I’m unable to pinpoint it to the root cause and prepare the repro sample. However, profiler show a 25% time is spend in SetterFactory:39 lambda.Compile();

the serialize is created with

.EnableAllConstructors()
.EnableParameterizedContentWithPropertyAssignments()
.Extend(WritableParameterizedContentExtension.Default)
.EnableImplicitTyping(allTypes.Where(x => !x.CustomAttributes.Any(a => a.AttributeType == typeof(CompilerGeneratedAttribute))))
.UseOptimizedNamespaces()

Any idea what could be root cause?

[jhranac]

The timings look much better now!

Version	Optimized namespaces	Disabled properties	Optimized namespaces; disabled properties	NOT optimized namespaces; properties enabled
3.1.2.3-rywdiqno	56 / 213	42 / 192	45 / 198	45 / 196

I’m happy with those results. Good job!

[jhranac]

We’re using the optimized namespaces - which in retrospect makes no sense in some of the cases so I’ll remove that. That should fix some of the performance issues for us.

Performance times - 100 iterations run to get an average. Times format: [serialize 1 element in array] / [serialize 100 elements in array] in milliseconds

Version	Optimized namespaces	Disabled properties	Optimized namespaces; disabled properties	NOT optimized namespaces; properties enabled
Release version	163 / 2272	40 / 176	40 / 184	73 / 215
Test version	140 / 369	40 / 183	43 / 175	71 / 207

So the fix you’ve done works! There is still some performance loss because the classes structure is scanned by the serializer even when a custom one is provided.