Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

removeLineBreaks causes inconsistency in text content spaces

See original GitHub issue

With the option removeLineBreaks: true in https://github.com/ndaidong/article-parser/blob/e0543954b4b00b5f7937a888754ebb395ed39d4a/src/utils/standalizeArticle.js#L39 the text spaces in many articles are replace with a line break \n. The words end up coming together (when not using a browser to display the result)

Here some screenshots examples with yarn eval ./test-data/regular-article.html

1. removeLineBreaks: true Captura de Tela 2022-03-25 às 01 27 09

2. removeLineBreaks: false Captura de Tela 2022-03-25 às 01 28 46

I think we can do improve the sanitizer

Issue Analytics

State:
Created a year ago
Comments:11 (6 by maintainers)

Top GitHub Comments

1reaction

andremacolacommented, Mar 25, 2022

Are you going to make it happen on your own? I don’t know if I want to start

Yep, I can do that.

0reactions

SettingDustcommented, Mar 25, 2022

removeLineBreaks in my opinion default should be false like html-crush defaults. But it’s irrelevant if we have a way to customize with sanitizeHtmlOptions

The output won’t display to user. So it’s fine in my mind.