AttributeError: 'NoneType' object has no attribute 'rstrip'

Getting the following error

AttributeError: 'NoneType' object has no attribute 'rstrip'

Python 3.7.6

[ezbz]

Closed by https://github.com/ezbz/gitlabber/commit/8be5131a852be06ecaed06542325879a47515d9f

[jrschumacher]

@ezbz @needleshaped sorry I was working on a patch. The issue is that there is no check whether or not the URL is defined. I can’t test this due to not knowing enough Python to get an environment setup, but here is a diff of what appears to be needed:

diff --git a/gitlabber/cli.py b/gitlabber/cli.py
index 845b37f..645b6be 100644
--- a/gitlabber/cli.py
+++ b/gitlabber/cli.py
@@ -1,6 +1,7 @@
 
 import os
 import sys
+from urllib.parse import urlparse
 import logging
 import logging.handlers
 import enum
@@ -18,6 +19,17 @@ def main():
         print(VERSION)
         sys.exit(0) 
 
+    if args.token is None:
+        print('Requires a valid token')
+        sys.exit(1)
+
+    try:
+        urlparse(args.url)
+    except ValueError:
+        print('Requires a valid url')
+        sys.exit(1)
+
+
     config_logging(args)
     includes=split(args.include)
     excludes=split(args.exclude)
@@ -84,13 +96,13 @@ def parse_args(argv=None):
         '-t',
         '--token',
         metavar=('token'),
-        default=os.environ.get('GITLAB_TOKEN'),
+        default=os.environ.get('GITLAB_TOKEN', None),
         help='gitlab personal access token https://docs.gitlab.com/ee/user/profile/personal_access_tokens.html')
     parser.add_argument(
         '-u',
         '--url',
         metavar=('url'),
-        default=os.environ.get('GITLAB_URL'),
+        default=os.environ.get('GITLAB_URL', 'https://gitlab.com'),
         help='gitlab url (e.g.: \'http://gitlab.mycompany.com\')')
     parser.add_argument(
         '--verbose',