Improve `addDirectory`

Currently addDirectory: "aaa" copies the sub directory of aaa under working directory in Lambda.

Project structure:

project-root
└── aaa
    └── bbb
        └── ccc
            └── file.js

Result:

working-dir-in-lambda
├── bbb
│   └── ccc
│       └── file.js
└── index.js

Is this intensional?

My expected behavior is coping aaa itself and the directory structure is preserved:

working-dir-in-lambda
├── aaa
│   └── bbb
│       └── ccc
│           └── file.js
└── index.js

The cause is the second arg false of archive.directory(). https://github.com/faastjs/faast.js/blob/2b22487a1c4466b0b5843cf8a897bb19f7a477f3/src/packer.ts#L94 If the second arg is omitted, it works as expected.

 archive.directory(await resolvePath(dir), false); 

ref. https://www.archiverjs.com/archiver#directory

[acchou]

After using addDirectory a bit, I think you are right that it’s confusing with these semantics, and should be changed.

[teppeis]

@acchou Awesome! The options and implementation are simplified and extensible. It works well in my project. Thanks!