Add support for alternate credential stores
See original GitHub issueIt would seem that in the latest versions of Docker, there may be a shift from Docker handling the storage of registry credentials in it’s ~/.docker/config.json
to using 3rd-party or OS provided credential managers. See the docker login reference and docker-crenetial-helpers project for more details on this and the implementation.
This is certainly, the default configuration as it stands for Windows as running docker login
will not add the older format of an auths
with server objects that have an auth
token (as happens with docker on Linux right now).
From what I can see, and I could be mistaken having only had a quick browse of the source online, but the current implementation relies on either a username
/password
pair in the config.json
or an auth
token. Implementation would require the checking of the credsStore
field with dispatch the appropriate implementation as well as concrete implementations being provided for osxkeychain
, secretservice
and wincred
.
I will reproduce and add the log output for the error when trying to pull or push from a windows system where it will use "credsStore": "win"
when I get a chance.
There has been some discussion on this with the #532 PR.
Issue Analytics
- State:
- Created 7 years ago
- Reactions:4
- Comments:10 (1 by maintainers)
Top GitHub Comments
What server tag did you add ? I’m sorry how was this issue fixed it’s not clear to me.
It seems that the <server> workaround above will not work nicely with AWS ECR since it generates a temporary user/password.
Is there a work around for AWS ECR?