ImageStream triggers break DeploymentConfigs on OpenShift

it seems moving to 3.4.0 of fmp adds mandatory ImageStreamChange triggers OOTB to DeploymentConfig which breaks them massively on OpenShift:

• using oc apply, mvn fabric8:deploy or gofabric8 deploy results in nothing being deployed at all. You have to then manually go into each DC and trigger it (e.g. via the Deploy button in the OpenShift console
• oc edit dc foo no longer updates the DC at all 😉

i.e. the DCs become pretty much utterly useless! 😃

So adding ImageStreamChange triggers OOTB sounds kinda scary. So lets at least make them optional for now (maybe defaulting to disabled to reduce breaking things?)

I wonder what the logic should be to ever include them since it seems to break things. Maybe we only enable them if we know that we are building the container image itself via an image stream? In my use case (the upstream fabric8 project) the images are public docker hub images and so are not built via ImageStreams

[rhuss]

The solution to make mode independent deployment descriptors (as it should) is in fact #678 (which is the very next on my task list. finally 😉

[jstrachan]

@rhuss enjoy your PTO! Lemme mark as closed as I think it is - we can always reopen if not