Can't close a watcher

Hello,

It seems the client is unable to close the HTTP connection while watching the pod. Indeed, an “OkHttp” thread is still running, waiting for content of the kubernetes API. I suspect the following code to cause the problem:

public class WatchConnectionManager<T, L extends KubernetesResourceList> implements Watch {
...

Request request = new Request.Builder()
      .get()
      .url(httpUrlBuilder.build())
      .addHeader("Origin", requestUrl.getProtocol() + "://" + requestUrl.getHost() + ":" + requestUrl.getPort())
      .build();
    clonedClient.setReadTimeout(0, TimeUnit.MILLISECONDS);

...

Indeed the timeout for the connection is set to 0, meaning there is no timeout at all.

Here is a minimal example of this problem (the program is still running after client.close() is displayed):

import io.fabric8.kubernetes.api.model.Pod;
import io.fabric8.kubernetes.client.*;


public class Test {
    public static void main(String[] args) {
        KubernetesClient client = new DefaultKubernetesClient();

        Watch watch = client.pods().inNamespace("default").watch(new Watcher<Pod>() {
            public void eventReceived(Action action, Pod pod) {
                System.out.println(pod.getMetadata().getResourceVersion());
            }

            public void onClose(KubernetesClientException e) {
                System.out.println("client closed");
            }
        });

        watch.close();
        client.close();
        System.out.println("client.close();");
    }
}

EDIT: Tested with kubernetes-client v1.3.82

[jimmidyson]

@ZenithKaizer Thanks for the info - will watch out for that. Wonder if it makes sense to have a timeout in the close somehow, although have to be careful of not leaking resources. Will think on that,

[ZenithKaizer]

@jimmidyson we were using kubemark release with hollow-nodes to emulate real nodes for testing purposes : https://github.com/kubernetes/kubernetes/blob/release-1.2/docs/proposals/kubemark.md. All were performing well then, except for this watch.close(); We just switch to standard kubernetes binairies and it works! Thanks …