BiomeSelectors.foundInOverworld() ignores custom biomes added via minecraft/dimension/overworld.json

Biome Modification API ignores mod biomes added in data pack loaded via ResourceManagerHelper.registerBuiltinResourcePack(Identifier, ModContainer, ResourcePackActivationType.ALWAYS_ENABLED). Perhaps loading via ResourceManagerHelper doesn’t matter. https://github.com/FabricMC/fabric/issues/1703#issuecomment-913061946

[mschae23]

Yes, it would be great to fix this, but I think it’s easier not to write dubious code and just rename methods like this:

vanillaOverworldBiomes();
vanillaNetherBiomes();
vanillaTheEndBiomes();

The problem is that it’s not just vanilla biomes, but also mod biomes added with the Biome API.

[mschae23]

BiomeSelectors.foundInOverworld() has no biomes added via minecraft/dimension/overworld.json, however, selection by category works (selection.getBiome().getCategory() == Biome.Category.DESERT).

foundInOverworld does not actually check which biomes generate in the overworld, but which biomes generate with minecraft:vanilla_layered.