foundInOverworld, foundInNether, foundInEnd helper methods are not safe for modded biome sources

All of Fabric team noticed that most modded ores will not spawn in BYG biomes. BYG is using Terrablender. Terrablender uses its own biome source. And Fabric API is using a field that’s very specific to the vanilla overworld biome source which is bad for mod compat and is breaking modpacks using Terrablender. Instead, Fabric API should be using the overworld’s biome source’s possibleBiomes field that they hold always which should have all biomes that can actually spawn in overworld. Or ideally, use the existing minecraft:is_overworld biome tag instead. This change should also be done for the nether and end helpers as well so all three helper methods functions properly regardless of the biome source used for the dimension.

https://github.com/FabricMC/fabric/blob/93d8cb82e85c3d5744716430516daef393cf5815/fabric-biome-api-v1/src/main/java/net/fabricmc/fabric/api/biome/v1/BiomeSelectors.java#L68-L92

These helpers seem to have issues as a somewhat similar issue happened in the past: https://github.com/FabricMC/fabric/issues/1703

[shartte]

Well it says specifically “assuming Vanilla’s default biome source is used.”. Since when these methods were created, it wasn’t really possible to do otherwise.

warjort is completely right.

To correct myself here by the way: The javadoc is actually incorrect. The method uses the real biome source used by the currently loading world, not just the Vanilla one.

[kwpugh]

Hi, sorry to randomly inject, but I’m updating my mods from 22w43a to 22w44a and I wanted to confirm that I am using the correct method to inject my ores into biomes correctly. I was getting a little confused about the discussion.

My code currently:

` public static void addOres() { // Inject into Biomes BiomeModifications.addFeature(overworldSelector(), GenerationStep.Feature.UNDERGROUND_ORES, RegistryKey.of(Registry.PLACED_FEATURE_KEY, new Identifier(Gobber2.MOD_ID, “ore_lucky_block_overworld”))); BiomeModifications.addFeature(overworldSelector(), GenerationStep.Feature.UNDERGROUND_ORES, RegistryKey.of(Registry.PLACED_FEATURE_KEY, new Identifier(Gobber2.MOD_ID, “ore_gobber_overworld”))); BiomeModifications.addFeature(netherSelector(), GenerationStep.Feature.UNDERGROUND_ORES, RegistryKey.of(Registry.PLACED_FEATURE_KEY, new Identifier(Gobber2.MOD_ID, “ore_lucky_block_nether”))); BiomeModifications.addFeature(netherSelector(), GenerationStep.Feature.UNDERGROUND_ORES, RegistryKey.of(Registry.PLACED_FEATURE_KEY, new Identifier(Gobber2.MOD_ID, “ore_gobber_nether”))); BiomeModifications.addFeature(endSelector(), GenerationStep.Feature.UNDERGROUND_ORES, RegistryKey.of(Registry.PLACED_FEATURE_KEY, new Identifier(Gobber2.MOD_ID, “ore_lucky_block_end”))); BiomeModifications.addFeature(endSelector(), GenerationStep.Feature.UNDERGROUND_ORES, RegistryKey.of(Registry.PLACED_FEATURE_KEY, new Identifier(Gobber2.MOD_ID, “ore_gobber_end”))); }

public static Predicate<BiomeSelectionContext> overworldSelector()
{
    return context -> context.getBiomeRegistryEntry().isIn(BiomeTags.IS_OVERWORLD);
}

public static Predicate<BiomeSelectionContext> netherSelector()
{
    return context -> context.getBiomeRegistryEntry().isIn(BiomeTags.IS_NETHER);
}

public static Predicate<BiomeSelectionContext> endSelector()
{
    return context -> context.getBiomeRegistryEntry().isIn(BiomeTags.IS_END);
}

`