Incompatibility with dependencyResolutionManagement setting in gradle

It seems that loom is incompatible with dependencyResolutionManagement. The problem is the same as the one described in this issue https://github.com/gradle/gradle/issues/15754.

To summarize, the three options in dependencyResolutionManagement are

• FAIL_ON_PROJECT_REPOS: a repository declared in the project will trigger a build error.
• PREFER_PROJECT: ignore repository declared in the settings.
• PREFER_SETTINGS: ignore repository declared in the project. based on documentation https://docs.gradle.org/current/javadoc/org/gradle/api/initialization/resolve/RepositoriesMode.html

Since loom declared its repository in the plugin, it will cause FAIL_ON_PROJECT_REPOS and PREFER_SETTINGS not to work. However, PREFER_PROJECT will cause the Gradle to ignore the repository declared in the settings, which can be problematic for large projects.

One solution might be to not declare a repo in the plugin, but I am not sure if it is possible.

[modmuss50]

I really don’t know enough about it to provide any useful input right now. When I get a chance I’ll take a look.

There is a huge amount of work to get loom up to speed with the new gradle changes. I do have a future/dev branch where I have started on the easy bits.

[LogicFan]

I suggest shipping an additional plugin that sets the repositories for the settings than making the same plugin work for both environments like sponge does. having the same plugin target two different things is quite confusing.

To have compatibility with the people who choose not to use dependencyResolutionManagement, the plugin needs to have the ability to declare repos in the project. Thus, the idea is if depedencyResolutionManagement is used, the repo will be declared in the settings, and if it is not used, the repo needs to be declared in the project. These two parts of the code share a great similarity, hence it makes sense to write them in the same plugin. Thus, I would prefer a solution similar to sponge vanillagradle.