Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Allow JSON with comments in jsconfig.json

See original GitHub issue

Is your proposal related to a problem?

This is a follow-on from #7248. Right now, we don’t support JSONC (JSON with comments) in jsconfig.json files.

Describe the solution you’d like

After a discussion with @iansu, we see two paths:

Implement the same solution as we did for TypeScript. This is easy, but would require us making TypeScript a dependency of react-scripts.
The above, but instead of installing typescript as a dependency of react-scripts, we would install it to the user’s project if they are using a jsconfig.json file and don’t have typescript installed.

Discussion is welcome.

If you’re interested in picking this up, please let us know.

Issue Analytics

State:
Created 4 years ago
Comments:13 (8 by maintainers)

Top GitHub Comments

2reactions

esvyridovcommented, Dec 11, 2019

@mrmckeb PR #8140 is ready

2reactions

miraagecommented, Jul 25, 2019

@mrmckeb we can pin TS version via react-dev-utils in that case, like cross-spawn and chalk.

Top Results From Across the Web

jsconfig.json Reference - Visual Studio Code

The jsconfig. json file specifies the root files and the options for the features provided by the JavaScript language service.

Why normal json files don't allow comments where as tsconfig ...

There is no configuration to allow comments in JSON, because JSON doesn't support comments. JSON-derived formats such as JSON5 do.

Documentation - What is a tsconfig.json - TypeScript

The tsconfig.json file specifies the root files and the compiler options required to compile the project. JavaScript projects can use a jsconfig.json file ......

Configuration Files - ESLint - Pluggable JavaScript Linter

JSON - use .eslintrc.json to define the configuration structure. ESLint's JSON files also allow JavaScript-style comments. package.json - create an ...

Do SFDX projects really need multiple jsconfig.json files?

When I launch VS Code, some extension is adding a jsconfig.json file to every lwc folder. It has the exact same structure each...