Click to Open Editor Feature of Error Overlay Documentation

Can you reproduce the problem with latest npm?

yes

Description

The Feature ‘click on the error overlay to open in editor’ expects an environment Variable called REACT_EDITOR (https://github.com/facebookincubator/create-react-app/pull/2141/files#diff-e891084243d9d79cbaff6e11eab1a4fdR82). However the documentation states, that any environment variable not starting with REACT_APP_* will get blocked.

Expected behavior

When writing REACT_EDITOR=wstorm (etc) into a .env.local File I expect the click to open editor Feature to work.

Actual behavior

The Feature does not work. When using console.log(process.env.REACT_EDITOR) in the code it logs undefined.

Environment

Run these commands in the project folder and fill in their results:

1. npm ls react-scripts (if you haven’t ejected): 1.0.7
2. node -v: 7.10.0
3. npm -v: 4.6.1

Then, specify:

1. Operating system: Windows 10
2. Browser and version: Chrome 58

Reproducible Demo

https://github.com/wirmar/cra-error-overlay-issue things to note in demo: .evn.local file console log

Other

This probably also blocks automatic detection of used Editor on windows via env vars EDITOR and VISUAL.

[miraage]

Thank you! I have also noticed that it might create /usr/local/bin/pstorm shortcut. I’ll open an issue about all Jetbrains IDEs this week with suggestion to unify all their products.

[gaearon]

Fixed in 1.0.8. Please verify. https://github.com/facebookincubator/create-react-app/releases/tag/v1.0.8