create-react-app enforces @typescript-eslint/no-namespace, a style rule

Describe the bug

1. create-react-app --typescript
2. Add a namespace in a file
3. I get the error: ES2015 module syntax is preferred over custom TypeScript modules and namespaces.eslint(@typescript-eslint/no-namespace). There seems to be no way to turn off this rule, according to #3886.

Why this is a bug:

From https://github.com/facebook/create-react-app/issues/2157#issuecomment-301452953:

Our rules are specifically picked to not enforce style, and to only find logical mistakes.

Whether or not a namespace is used is most definitely not a choice of style and not a logical mistake. Please remove this rule or give me an option to remove this rule.

[szhu]

Hey @cordasfilip! I think that this could be an unrelated issue, and I’d recommend creating a new GitHub issue to discuss that. If you think that people reading that issue should read this issue too, you can link to this issue there.

Since I’m already here, here are some thoughts that come to mind:

• I think VSCode doesn’t run eslint on ts files by default, so that’s why VSCode isn’t showing the errors. Here are some keywords that can help you fix that.

• If you replace location with window.location, does it work?

• If debugging is required, it might be helpful if you could list of specific reproduction steps. When you make a new Github issue, the template will prompt you to do so.

[szhu]

Btw, there’s one warning I have left. At this point I should probably explain my use case:

namespace Counter {
  interface Props {
    value: number
    setValue: (value: number) => void
  }
}

const Counter: React.FC<Counter.Props> = (props) => {
  return <div>{value}</div>
}

export default Counter

Basically, I don’t want to export/use props separately from the component.

---

For this example, the proposed fixes will make it work! But I’m still left with this warning:

Compiled with warnings.
  'Counter' is already defined  no-redeclare

Let me know what you think. Should no-redeclare also be removed? Is the props organization convention a bad one? Is there a way to achieve the same effect without namespaces? Also let me know if you think this is worthy of a separate issue.