question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

doesn't respect .eslintignore

See original GitHub issue

Can you reproduce the problem with latest npm?

yes

Description

create-react-app 1.x doesn’t respect .eslintignore. (It was use to respect it on version 0.9.x).

Expected behavior

Not showing ESLint warning/errors of files in the .eslintignore file

Actual behavior

See warning such as:

Compiled with warnings.

./src/vendor/modernizr.js
  Line 25:   Shadowing of global property 'undefined'     no-shadow-restricted-names
  Line 163:  Do not use Boolean as a constructor          no-new-wrappers
  Line 431:  Unexpected string concatenation of literals  no-useless-concat
  Line 436:  Expected '===' and instead saw '=='          eqeqeq

Search for the keywords to learn more about each warning.
To ignore, add // eslint-disable-next-line to the line before.

Environment

Run these commands in the project folder and fill in their results:

  1. npm ls react-scripts (if you haven’t ejected): react-scripts@1.0.5
  2. node -v: v6.10.0
  3. yarn -v: v0.24.5

Then, specify:

  1. Operating system: OSX Sierra
  2. Browser and version: *

Reproducible Demo

.eslintignore :

vendor/*.js
src/vendor/*.js
src/vendor/vendor.js

src/vendor.js:

(function(undefined) {
  var a = 1;
  var b = a == 1;
  window.$someProp$ = b;
}());

src/index.js:

import "./vendor/vendor.js";

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:20 (5 by maintainers)

github_iconTop GitHub Comments

25reactions
Timercommented, May 23, 2017

CRA 1.x+ purposely does not support .eslintignore. Sorry!

Please move vendor files into public/ or use a NPM package.

9reactions
TennyZhuangcommented, Oct 3, 2017

really need .eslintignore for *_pb.js produced by protobuf, is there some workaround now?

Read more comments on GitHub >

github_iconTop Results From Across the Web

ESLint doesn't respect the .eslintignore and hangs on ... - GitHub
Just clone it, run yarn and then yarn test . What did you do? Please include the actual source code causing the issue,...
Read more >
how to silence warnings about ignored files in eslint
One workaround I know at the moment is --quiet option, which suppresses all warnings. Of course that doesn't make sense if you have...
Read more >
Ignoring Code - ESLint - Pluggable JavaScript Linter
A pluggable and configurable linter tool for identifying and reporting on patterns in JavaScript. Maintain your code quality with ease.
Read more >
How to use Prettier with ESLint - Robin Wieruch
How to combine Prettier and ESLint for VSCode, Sublime, or any other IDE/editor. You will get to know the ESLint Prettier Rules that...
Read more >
Allow use of .semgrepignore file in Semgrep-based SAST ...
Proposal The Semgrep-based SAST analyzer doesn't respect a user-committed .semgrepignore file today. In.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found