Experience `yarn start` failure in CI

Describe the bug

CRA 3.3.0 worked great, and then all versions after it seem to fail our CircleCI builds because we use yarn start to run e2e tests.

This is a pretty big breaking change to CI tools like CircleCI and docker-compose.

Relates to https://github.com/facebook/create-react-app/issues/8688

Did you try recovering your dependencies?

Yes and only when reverting to CRA 3.3.0 does it work again.

Using yarn version 1.16 and node 10.16

Environment

linux node10 docker container

Steps to reproduce

1. Upgrade to CRA >3.3.0
2. Run yarn start as a background test in CircleCI or any docker-linux env (works fine CRA <=3.3.0)
3. Fails (>3.3.0) or exits with error code 1 (as of 3.4.1)

Expected behavior

That it wouldn’t exit as a failure when it’s not a failed process

Actual behavior

background task exits as a failed process

CRA 3.3.1 does this after yarn start:

#!/bin/bash -eo pipefail
yarn start
yarn run v1.16.0
$ yarn css
$ node-sass src/css/styles.scss src/css/styles.css
Rendering Complete, saving .css file...
Wrote CSS to /root/project/src/css/styles.css
$ tachyons src/css/styles.css > src/css/app.min.css --minify
Node#moveTo was deprecated. Use Container#append.
$ concurrently -r -k "yarn css:watch" "react-scripts start"
$ chokidar "src/css/*.scss" -c "yarn css"
Watching "src/css/*.scss" ..
ℹ ｢wds｣: Project is running at http://172.26.0.3/
ℹ ｢wds｣: webpack output is served from /
ℹ ｢wds｣: Content not from webpack is served from /root/project/public
ℹ ｢wds｣: 404s will fallback to /index.html
Starting the development server...

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type undefined
    at validateString (internal/validators.js:125:11)
    at Object.join (path.js:1147:7)
    at noopServiceWorkerMiddleware (/root/project/node_modules/react-scripts/node_modules/react-dev-utils/noopServiceWorkerMiddleware.js:14:26)
    at Layer.handle [as handle_request] (/root/project/node_modules/express/lib/router/layer.js:95:5)
    at trim_prefix (/root/project/node_modules/express/lib/router/index.js:317:13)
    at /root/project/node_modules/express/lib/router/index.js:284:7
    at Function.process_params (/root/project/node_modules/express/lib/router/index.js:335:12)
    at next (/root/project/node_modules/express/lib/router/index.js:275:10)
    at launchEditorMiddleware (/root/project/node_modules/react-scripts/node_modules/react-dev-utils/errorOverlayMiddleware.js:20:7)
    at Layer.handle [as handle_request] (/root/project/node_modules/express/lib/router/layer.js:95:5)

CRA 3.4.1 simply exits with no useful error message: With no error log, I might add. sucks to debug. Even SSH into container reveals nothing useful.

[rassie]

This is most certainly a duplicate of #8688, at least in my environment.

[stale[bot]]

This issue has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue.