Large builds because of process.env

As mentioned in https://github.com/facebookincubator/create-react-app/pull/807#issuecomment-254051846

Description

Such approach can result in large development builds, if process.env.NODE_ENV is used frequently in code… I’t because each time it becomes { whole: "config", NODE_ENV: "dev", ... }.NODE_ENV.

Expected behavior

I think the better approach is to create definitions for both, so we get short aliases if possible and at the same time process.env is fully supported. That is create both mappings:

process.env.FOOBAR = 'xxx';
process.env = { FOOBAR: 'xxx' };

for each defined FOOBAR variable.

[thien-do]

Hi guys, I can do this PR if @sheerun is busy. Is this what you are looking for: https://github.com/dvkndn/create-react-app/commit/3166668b638634d3c6411249b814045b58c7f2e5

If it is ok, should I create a PR? Also, I’m not sure if this is the best way to do that, but I’m willing to fix if you have any suggestion.

[oriSomething]

It seems this issue returned in react-scripts@1.1.0. The only different that the process.env object is wrapped with Object: Object({NODE_ENV:…}).NODE_ENV