@license comments are not preserved during build
See original GitHub issueIs this a bug report?
Yes
Did you try recovering your dependencies?
Yes. Yarn version: 1.6.0
Which terms did you search for in User Guide?
I was asked to file a bug report in issue #4116.
Environment
npx: installed 67 in 14.97s
Environment:
OS: macOS High Sierra 10.13.3
Node: 9.7.1
Yarn: 1.6.0
npm: 6.0.0
Watchman: Not Found
Xcode: Xcode 9.3 Build version 9E145
Android Studio: Not Found
Packages: (wanted => installed)
react: ^16.0.0 => 16.4.0
react-dom: ^16.0.0 => 16.4.0
react-scripts: ^1.1.4 => 1.1.4
Steps to Reproduce
./src/index.js
contains the following comment:
/**
* @license Copyright (c) Conscious Apps Inc. All Rights Reserved.
* Written by Martin Adams https://github.com/heymartinadams
*/
- Run
react-scripts build
.
Expected Behavior
On running react-scripts build
, however, comment isn’t preserved in resulting ./build/static/js/main.*.js
file, even though (as issue #4116 states), create-react-app
ought to preserve JSDoc-style comments.
Actual Behavior
Missing @license
comment in ./build/static/js/main.*.js
file.
Issue Analytics
- State:
- Created 5 years ago
- Comments:8
Top Results From Across the Web
How can I remove License comment from the bundle ... - HUGO
In most cases you are violating the license by removing it. That's why most minifiers retain the license by default. Go find those...
Read more >licensing - What can I assume if a publicly published project ...
If a repository has no license, then all rights are reserved and it is not Open Source or Free. You cannot modify or...
Read more >android - You have not accepted the license agreements of ...
I solved this issue by firing ./sdkmanager --licenses and accepting all the licenses. You have a sdkmanager.bat under the android sdk folder in...
Read more >PKGBUILD - ArchWiki
Any package licensed under these five should have its own unique license file stored in /usr/share/licenses/pkgname/ . Some packages may not be ...
Read more >PEP 639 – Improving License Clarity with Better Package ...
This specification builds off of existing ways to document licenses ... This PEP also is not about license documentation in files inside ...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Mmh… I still didn’t get it (in some areas, like git, I’m a complete beginner). How about this? It’s not a high-priority issue for me, and I trust you all, so if you say you fixed it, pretty sure it works? (Sorry, don’t mean to be difficult, just super focused on a project and can’t spend too much time on other things at the moment.)
This issue has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue.