question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Peer dependencies of eslint-config-react-app should probably be regular dependencies

See original GitHub issue

If user wants only the config and nothing else the one should still install all the deps, which can be done automatically and with no hassle.

Currently, I have to install eslint-plugin-flowtype which I am not even using in my project…

Moreover, version of babel-eslint is outdated (available: 10, listed: 9).

As one of the solutions, maybe, we can create one extra package in this repo and name it like eslint-config-react-app-pack, which will have all the needed deps?

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Reactions:14
  • Comments:16 (5 by maintainers)

github_iconTop GitHub Comments

2reactions
tlrobinsoncommented, Apr 9, 2019

I agree with @kirill-konshin and @skoestler that eslint-config-react-app should mirror the behavior of babel-preset-react-app by including its dependencies as regular dependencies.

I set up a project that mirrors create-react-app’s Babel and ESLint config and about half of the dependencies in my package.json are eslint-config-react-app’s dependencies. It would be nice to trim that down so that one could just add eslint-config-react-app without having to track down all of the dependencies.

1reaction
skoestlercommented, Mar 10, 2019

I have a project that is just a component library so I’m not using create-react-app but I wanted the tooling to be consistent with our CRA projects so using babel-preset-react-app and eslint-config-react-app is a great option (I really appreciate that they are published as they are).

I did find it odd that babel-preset-react-app includes all of the plugins as dependencies and eslint-config-react-app uses peer dependencies.

I admit that I could totally be missing the reason for why they are different, but in my case this change would be helpful.

Read more comments on GitHub >

github_iconTop Results From Across the Web

How to fix the peer dependencies Installation problem
You must install peer dependencies yourself. npm WARN eslint-config-react-app@4.0.1 requires a peer of eslint@5.x but none is installed. You ...
Read more >
Set Up ESLint - The newline Guide to Modernizing an ...
If your app needs a dependency (like "react" ) to run in production, "react" should be included in the "dependencies" array. If an...
Read more >
M220JS: Errors at installation - MongoDB
Hello, I've got this error message: C:\Users\rober\Downloads\mflix-js>npm install npm ERR! code ERESOLVE npm ERR! ERESOLVE could not resolve
Read more >
eslint-config-standard - npm
The above steps will automatically set up an ESLint configuration and install the necessary dependencies for you. If you want to set up...
Read more >
eslint/eslint - Gitter
npm WARN eslint-plugin-react@6.10.3 requires a peer of eslint@^2.0.0 || ^3.0.0 but none is installed. You must install peer dependencies yourself.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found