react-dev-utils/webpackHotDevClient - SockJS - non-customisable host and port

Hello.

I have a question about the react-dev-utils/webpackHotDevClient.

SockJS there (see https://github.com/facebookincubator/create-react-app/blob/next/packages/react-dev-utils/webpackHotDevClient.js#L64) is instantiated with not customized host and port but with the corresponding parameters of the original window.

Is it intended and/or are there any strict contraindications against customizing host and port?

If yes, what’s the explanation? If not, would it make sense if I handle this issue and make a PR?

Thank you!

[AlexMiroshnikov]

@tharakawj Thank you for reaction. I do understand what happens on those lines.

If you want to customize port and host of the webpack dev server you can easily change them via environment variables.

Of course I know about this option, and I even use it, but imagine that I have another application which should be able to talk to the webpack dev server. Say, webpack dev server is available by localhost:3000 and I have, for example, anotherapp.local, and I want anotherapp.local to talk to the running webpack dev server, with hot replacement and all that useful things. With the current implementation, if works pretty fine until the moment Sock tries to connect to dev server - instead of establishing connection with localhost:3000, it tries ws://anotherapp.local and, of course, fails.

So why exactly not to customize the parameters?

[anasanzari]

+1