Yarn PnP is not compatible with optional peer dependencies

This makes PnP incompatible with how we’re shipping Sass and planning to ship future enhancements (e.g. TypeScript).

Optional peer dependencies are vital to keeping initial install sizes low (less of a problem with PnP, but imagine a cache miss).

See broken test:

./src/AppSass.scss
- To import Sass files, you first need to install node-sass.
- Run `npm install node-sass` or `yarn add node-sass` inside your workspace.
+ Error: Package "sass-loader@7.1.0" (via "/Users/joe/Library/Caches/Yarn/v3/npm-sass-loader-7.1.0-16fd5138cb8b424bf8a759528a1972d72aad069d/node_modules/sass-loader/lib/loader.js") is trying to require the package "node-sass" (via "node-sass") without it being listed in its dependencies (webpack, clone-deep, loader-utils, lodash.tail, neo-async, pify, semver, sass-loader)

[arcanis]

@timer 😢 Not an option because of the warning, right? Is there something else, or would fixing this in Yarn be good enough for you?

@bugzpodder It also depends on how you’ll want the cra users to specify that they want to use dart-sass, but overall it shouldn’t be an issue with PnP, since it’s the configuration file that will make the require call, not node-sass itself (otherwise it would have to declare it as an optional peer dependency as well - once available).

[iansu]

Can you try the latest release and see if this has improved? If not please open a new issue.