question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

improvement(v2): typography

See original GitHub issue

🚀 Feature

The default settings for Infima provide tight line heights, which is hard to comprehend, especially on desktop. Also, the root font size is overridden by a small, pixel-based value, which is bad for accessibility.

Have you read the Contributing Guidelines on issues?

Yes.

Motivation

Improve legibility and accessibility of the default theme.

Implementation

:root {
  --ifm-font-size-base: 100%;
  --ifm-code-font-size: 93.75%; /* 15/16, one px smaller than the base font */
  --ifm-line-height-base: 1.75; /* Instead of 1.5 */
  --ifm-leading-desktop: 1.25; /* Instead of 1.5 */
  --ifm-list-margin: var(--ifm-leading); /* Keep consistent with the leading */
}

Comparison

image

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:6 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
yangshuncommented, May 17, 2020

–ifm-list-margin: var(–ifm-leading) doesn’t seem to be done in infima@0.2.0-alpha.8:

In markdown.css there’s .markdown ul which adds a bottom margin of --ifm-leading already, so this doesn’t do anything.

Closing this issue as we’ve implemented the changes in Infima and will release a new version soon.

1reaction
lex111commented, Apr 27, 2020

–ifm-font-size-base: 100%; – Users like to specify the preferred font size in their browsers. Bigger is okay, but anything smaller than 100% for body text should raise accessibility concerns.

I agree about this, it’s really best not to override the default font size.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Improvement Font : Download Free for Desktop & Webfont
Download Improvement font for PC/Mac for free, take a test-drive and see the entire character set. Moreover, you can embed it to your...
Read more >
Typography Hacks: 5 Greatest Tips to Improve Your Design ...
Typography guide that every designer must know. Transform boring and dull website designs, improve your skills immediately at ease.
Read more >
Improve your designs with these typography tips - UX Collective
Typography gives character to your design so choose wisely. Limit type pairings to 2 or 3 max. Try not to use too many...
Read more >
8 Simple Ways to Improve Typography In Your Designs
Here are 8 simple ways you can use CSS to improve your typography and hence the overall usability of your designs.
Read more >
Improved Typography Options in Astra - Astra WordPress Theme
The following steps will guide you through. Step 1: Navigate to the WordPress dashboard. Step 2: Click on Appearance and choose customize. Customizer....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found