question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

flow 0.30.0 is broken with draft-js 0.8.1 (4 errors)

See original GitHub issue

Minimal repro at https://github.com/etrepum/repro-draft-js-flow-issue with tests failing at https://travis-ci.org/etrepum/repro-draft-js-flow-issue

Launching Flow server for /home/travis/build/etrepum/repro-draft-js-flow-issue
Spawned flow server (pid=2802)
Logs will go to /tmp/flow/zShomezStraviszSbuildzSetrepumzSrepro-draft-js-flow-issue.log
node_modules/draft-js/lib/DraftBlockRenderConfig.js.flow:15
 15: import type React from './react';
                            ^^^^^^^^^ ./react. Required module not found

node_modules/draft-js/lib/DraftEditorProps.js.flow:47
 47:   ; blockRendererFn?(block: ContentBlock): ?Object
                         ^ Unexpected token (

node_modules/draft-js/lib/getUpdatedSelectionState.js.flow:24
 24:   if (__DEV__) {
           ^^^^^^^ identifier `__DEV__`. Could not resolve name

node_modules/fbjs/lib/Deferred.js.flow:60
 60:     Promise.prototype.done.apply(this._promise, arguments);
                           ^^^^ property `done`. Property not found in
500: declare class Promise<+R> {
     ^ Promise. See lib: /tmp/flow/flowlib_3e812a39/core.js:500


Found 4 errors
npm ERR! Test failed.  See above for more details.

I was able to work around this with draft-js 0.7.0 with the following flowconfig ignores (these no longer seem sufficient and were isolated to fbjs rather than draft-js, so it seems like a regression):

[ignore]
<PROJECT_ROOT>/node_modules/fbjs/lib/Deferred.*
<PROJECT_ROOT>/node_modules/fbjs/lib/equalsSet.*
<PROJECT_ROOT>/node_modules/fbjs/lib/everySet.*
<PROJECT_ROOT>/node_modules/fbjs/lib/PromiseMap.*
<PROJECT_ROOT>/node_modules/fbjs/lib/someSet.*
<PROJECT_ROOT>/node_modules/fbjs/lib/UnicodeBidi.*

Issue Analytics

  • State:closed
  • Created 7 years ago
  • Reactions:3
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
zpaocommented, Aug 19, 2016

I just fixed the DraftBlockRenderConfig issue fixed in #604. We’re getting there…

0reactions
etrepumcommented, Sep 19, 2016

Everything looks like it works now with the latest draft and flow https://github.com/etrepum/repro-draft-js-flow-issue 👍

Read more comments on GitHub >

github_iconTop Results From Across the Web

Issues and Pitfalls - Draft.js
This article addresses some known issues with the Draft editor framework, as well as some common pitfalls that we have encountered while ...
Read more >
Correct way to setup Flow with draft-js - Stack Overflow
However, when I run flow command, I don't get any errors when I call draft-js API. What is the correct way to setup...
Read more >
Changelog - Cypress Documentation
Compile errors are now surfaced in the command log during tests for Angular and Next projects. Fixes #23219. The error "Automatic publicPath is...
Read more >
conda-forge - :: Anaconda.org
A software package for algebraic, geometric and combinatorial problems... 7za, 9.20, LGPL, X, A file archiver with a high compression ratio. 7zip, 19.00 ......
Read more >
draft-js | Yarn - Package Manager
A React framework for building text editors. draftjs, editor, react, richtext. readme. draftjs-logo. Draft.js. Build Status npm version. Live Demo ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found