Support flipper plugins that contain a scope in their name

🐛 Bug Report

My team has been experimenting with publishing our custom desktop plugins to Github packages (developers then install them by downloading a tarball and using the “install from file” flow within the Flipper desktop app).

Github packages requires packages to have a scope in their name. When installing a plugin named @tinyspeck/flipper-plugin-$pluginName, I don’t see the plugin visible in Flipper’s sidebar or the “manage plugins” page, and I see this error logged in the developer tools window:

Uncaught (in promise) Error: ENOENT: no such file or directory, open '/Users/jschear/.flipper/thirdparty/@tinyspeck/package.json'

This may be more of a feature request (flipper-pkg lint complains about the name not starting with flipper-plugin-, after all) – is this something Flipper could support?

To Reproduce

1. Create a new flipper plugin with flipper-pkg init
2. Modify the name by adding a scope: @scope/flipper-plugin-$pluginName
3. Run yarn pack (you’ll need to modify the package.json to ignore the output of flipper-pkg lint in the prepack script).
4. Within the Flipper desktop app, install the plugin from file.

Environment

Flipper 0.51.0, macos 10.15.4

[nikoant]

“live-plugin-manager” is not used for plugin format v2, we’ll remove this dependency soon. So it seems like this limitation is just a side effect of having a slash character.

[nikoant]

This is fixed in #1427 and will be releases with the next Flipper version. For now you can test this by building manually from sources using command “cd flipper/desktop && yarn build --mac” which will output binaries to “flipper/dist” folder.