.setDownsampleEnabled(true) then resize don't work for webp with at least Android API =17
See original GitHub issueHello,
Testing Fresco with .setDownsampleEnabled(true) on one API 17 device, I don’t have the downsample fresco logs (RequestLoggingListener).
With another device, that is API 10, files are well downsampled. I could see the RequestLoggingListener lines.
The API 10 device, with same Fresco settings (downsample and resize to same size) is fastest (about x2 to x4 ) to decode picture that the API 17 one.
API 10 :
RequestLoggingListener: time 210302582: onProducerFinishWithSuccess: {requestId: 11, producer: DecodeProducer, elapsedTime: 273 ms, extraMap: {bitmapSize=1600x1067, queueTime=0, imageType=DEFAULT, isFinal=true, hasGoodQuality=true}}
API 17 :
RequestLoggingListener: time 89545018: onProducerFinishWithSuccess: {requestId: 52, producer: DecodeProducer, elapsedTime: 928 ms, extraMap: {bitmapSize=1600x1067, queueTime=2, imageType=DEFAULT, isFinal=true, hasGoodQuality=true}}
On API 10, I can find the Downsample log line :
DownsampleUtil: Downsample - Specified size: 2048x2048, image size: 1600x1067 ratio: 1.3 x 1.9, ratio: 1.919 for http://domain.tl/picture.jpg
Thus I can’t in API 17.
I have read this (http://frescolib.org/docs/configure-image-pipeline.html#_) and see downsample is experimental, but which Android version are supported, and which are not ?
This have been tested with fresco 0.10.0, 0.11.0. All tested pictures are prefetch to disk and stored there before to be displayed.
Greatings,
Eric
Issue Analytics
- State:
- Created 7 years ago
- Comments:19 (19 by maintainers)
Top GitHub Comments
Hello,
as libwebp 0.5.1 is now merged in Fresco/Master (https://github.com/facebook/fresco/pull/1388).
I deleted all branches, from my repository, with previous libwebp versions.
Branche with downsample enable for webp (to test) is here : https://github.com/eldk/fresco/tree/mDownSample (diff is here : https://github.com/eldk/fresco/commit/8e91c71c7d0aece81a2cbf7381cabe6754e84cca)
@oprisnik , thanks.
Should you have a look here :
https://groups.google.com/forum/#!topic/mod-pagespeed-discuss/GbntPnwiGTU
that’s not a direct matter but should enhance the use of Fresco and the app user respect on “get what you need, for what you should expect from what your device can do”.