Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

SVG support toggle not working

See original GitHub issue

Description

Case 1: (In showcase app) Turned on SVG support and expected SVG image to load. SVG image does not load. Case 2: (In showcase app) Turned off SVG support and expected app to re-attempt loading of SVG. Instead, nothing changed.

If Showcase app is restarted and SVG support is already “on”, SVG image loads.

Reproduction

Run showcase app.
Turn on/off SVG support.

Solution

(ImageFormatSvgFragment.java) Amend switchCompat.setOnCheckedChangeListener() so that image is re-loaded after the status of the toggle is changed.

Additional Information

Fresco version: 1.4.0
Platform version: SDK 23

Issue Analytics

State:
Created 6 years ago
Comments:7 (7 by maintainers)

Top GitHub Comments

1reaction

oprisnikcommented, Jan 16, 2018

This has been implemented. A toggle will be shown to inform you that the app needs to be restarted.

0reactions

a-d-collinscommented, Feb 12, 2018

Awesome! Thanks for letting me know!

On Tue, Jan 16, 2018 at 10:38 AM, Alexander Oprisnik < notifications@github.com> wrote:

This has been implemented. A toggle will be shown to inform you that the app needs to be restarted.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/facebook/fresco/issues/1850#issuecomment-358001824, or mute the thread https://github.com/notifications/unsubscribe-auth/AEwtyED7p_itmkUHpQOYT2GHfiXtlt6eks5tLMKNgaJpZM4OnrTJ .