results.success is always false in custom reporter onRunComplete

Logging results from onRunComplete in MyCustomReporter shows success is false even though all tests pass.

MyCustomReporter in tests/my-custom-reporter.js:

class MyCustomReporter {
  constructor(globalConfig, options) {
    this._globalConfig = globalConfig
    this._options = options
  }

  onRunComplete(contexts, results) {
    console.log({ results })
  }
}

module.exports = MyCustomReporter

jest config in package.json

  "jest": {
    "testEnvironment": "node",
    "reporters": [
      "./tests/my-custom-reporter.js"
    ]
  }

jest output (note success: false even though numFailedTests: 0)

$ node ./node_modules/.bin/jest path/to/tests.spec.js
 PASS  path/to/tests.spec.js
  outer
    ✓ works outer (1ms)
    inner
      ✓ works inner (1ms)

Test Suites: 1 passed, 1 total
Tests:       2 passed, 2 total
Snapshots:   0 total
Time:        0.352s, estimated 1s
Ran all test suites matching /path\/to\/tests.spec.js/i.
{ results:
   { numFailedTestSuites: 0,
     numFailedTests: 0,
     numPassedTestSuites: 1,
     numPassedTests: 2,
     numPendingTestSuites: 0,
     numPendingTests: 0,
     numRuntimeErrorTestSuites: 0,
     numTotalTestSuites: 1,
     numTotalTests: 2,
     openHandles: [],
     snapshot:
      { added: 0,
        didUpdate: false,
        failure: false,
        filesAdded: 0,
        filesRemoved: 0,
        filesUnmatched: 0,
        filesUpdated: 0,
        matched: 0,
        total: 0,
        unchecked: 0,
        uncheckedKeysByFile: [],
        unmatched: 0,
        updated: 0 },
     startTime: 1535648815628,
     success: false,
     testResults: [ [Object] ],
     wasInterrupted: false } }

[Rand01ph]

Maybe we assume that it’s failed until it’s passed and somewhere along the line we dropped setting success = true. Looks like this line attempts to set it to true

I found this Issue still exists in the latest version. For custom reporter, success is set after report generated, so what does this success symbol mean? I found move await this._dispatcher.onRunComplete(contexts, aggregatedResults); after aggregatedResults.success = ! ... will fix the issue, but I’m not sure for other logics

[github-actions[bot]]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.