test.only should be scoped to its describe

🐛 Bug Report

In a describe, I have a bunch of tests that should be executed only when a certain condition is fulfilled. One official solution is to use test.only.

The problem is that if the condition is truthy, no other test in the entire test file, that is, in different describes, gets executed. Instead, I see Pending test 'xxx' for every single test in all describes.

To Reproduce

describe('always run', () => {
  test('add', () => {
    expect(1 + 2).toBe(3);
  });
});

describe('run conditionally', () => {
  if (true) test.only('skipping all other things', () => {
    console.warn('skipping tests');
  });
  test('mul', () => {
    expect(2 * 3).toBe(6);
  })
});

Expected behavior

Only the tests in the describe block containing the test.only call should be skipped. Otherwise, test.only is a kill switch for the entire test file.

Link to repl or repo (highly encouraged)`

https://repl.it/repls/SillyPastDictionary

[thymikee]

This is certainly not a bug, but rather a feature request. We can discuss if it makes sense to scope test.only to a describe. IMHO we shouldn’t, because it exists to focus on a single test case. Or a whole describe with describe.only.

[SimenB]

I don’t think we should do this. only means “only this” (or “these” if added to multiple tests) within a test suite (file), not just within its describe. This is, afaik, also the case in other test runners with the same describe API (at least mocha)