Crash with synchronized - new in 0.26

This sample code:

class Foo {
  companion object {
    var instance: Foo? = null

    fun getInstance() {
      return instance ?: synchronized(Foo::class) {
        Foo().also { instance = it }
      }
    }
  }
}

crashes the formatter with

error: did not generate token "("
com.google.googlejavaformat.FormattingError: 9:51: error: did not generate token "("

        at com.google.googlejavaformat.OpsBuilder.sync(OpsBuilder.java:231)
        at com.facebook.ktfmt.KotlinInputAstVisitorBase.sync(KotlinInputAstVisitorBase.kt:2298)
        at com.facebook.ktfmt.KotlinInputAstVisitorBase.visitLambdaExpression(KotlinInputAstVisitorBase.kt:806)
 ...

The formatter handled this fine in 0.25.

[steventrouble]

Example pull request here that I think should fix the issue, but I won’t be able to test it for regressions on real code until tomorrow or possibly later this week: https://github.com/facebookincubator/ktfmt/pull/244

[steventrouble]

SG, thanks Carmi!