question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Incorrect handling for overlapping holiday dates

See original GitHub issue

The generated_holidays table in R contains a non-existing holiday, Bevrijdingsdag, Hemelvaart, that is actually a concatenation of two holidays (Bevrijdingsdag and Hemelvaart) that happen to coincide in that year, but in general do not fall on the same date.
This has prophet fit a coefficient for this joint holiday instead of the separate holidays. A tidyr::separate_rows(holiday, sep = ", ") fixes this, but it should maybe be fixed in the source data instead.

> prophet::generated_holidays %>% filter(country == "NL", ds == "2005-05-05")

          ds                    holiday country year
1 2005-05-05 Bevrijdingsdag, Hemelvaart      NL 2005

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:8 (8 by maintainers)

github_iconTop GitHub Comments

1reaction
raffgcommented, Sep 3, 2020

Quick update, the Idaho MLK holiday has been updated in the beta branch of holidays: https://github.com/dr-prodigy/python-holidays/pull/354. I searched all countries and I believe this is the last remaining comma in a holiday name. Once this beta branch is merged with master, Prophet should not have any more issues with overlapping holiday dates.

1reaction
blethamcommented, Aug 28, 2020

Thanks for fixing this @raffg! I updated the R generated file too, so this should all be fixed (pending the upstream fix).

Read more comments on GitHub >

github_iconTop Results From Across the Web

How To Manage Overlapping and Conflicting Time Off ...
“The best way to avoid vacation conflicts is to address it before the conflict ever exists with a detailed and clear vacation policy,”...
Read more >
calender overlapping issue occured - Microsoft Community
I want to assign the meeting online with the calendar but it is showing that you overlap the meeting so schedule it at...
Read more >
Claims overlap FAQ -- What is a claim overlap? - FCSO
A: An overlap is when an incorrect claim is processed and posted to the Common Working ... Different provider -- dates of service...
Read more >
Dealing with overlapping schedules - ServiceNow Community
I create schedule templates for both but using them in on-call schedule throws overlapping errors. Any suggestions how can I handle them?
Read more >
Will it be okay to overlap your end date at your current job and ...
If earned vacation, then yes. Other time would depend on company policy. Many companies don't pay out unused sick or personal time but...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found