Bug: [eslint-plugin-react-hooks] RuleOfHooks does not find conditional hook if HOC (e.g. mobx "observer") applied directly

React version: 16.13.1

Steps To Reproduce

1. Create a component using a conditional hook
2. Wrap the component with a HOC, e.g. mobx observer

Example

function HOC<T>(c: T): T { return c; }

const ConditionalHookComp = HOC(
    ({ flag }): JSX.Element => {
        if (flag) {
            useEffect(() => console.log("something"));
        }
        return <></>;
    });

The current behavior

The linter does not issue a warning/error for the conditional use of hooks, unless you remove the HOC.

The expected behavior

The linter issues a warning/error for the conditional use of hooks regardless whether the component is wrapped by an HOC or not.

[eps1lon]

It’s still kind of weird cause without the HOC wrapper it’s still an unnamed function, just assigned to a variable. So not really consistent in my opinion.

const ConditionalHookComp = () => {}

is not an unnamed function (console.log(ConditionalHookComp.name); // "ConditionalHookComp").

[ahoisl]

You are right, my mistake, name is inferred. We will probably need to follow some pattern for the observer HOC in our project if we want the linter support. Thank you for your support!