question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Bug: ReactArt-test fails with new node version

See original GitHub issue

Steps To Reproduce

  1. Use node 10
  2. git checkout master
  3. yarn test ReactArt

The current behavior

The following tests fail with in <anonymous> (at **) as the stack instead of the full component stack:

  • ReactARTComponents › should warn if radius is missing on a Circle component
  • ReactARTComponents › should warn if width/height is missing on a Rectangle component
  • ReactARTComponents › should warn if outerRadius/startAngle/endAngle is missing on a Wedge component

The expected behavior

I’m not familiar with react-art so it’s unclear whether node 12 needs to be used for local development (.nvmrc should be updated) or whether react-art should work with node 10.

Context

Bisecting leads to 98d410f5005988644d01c9ec79b7181c3dd6c847 which got introduced in #18561. /cc @sebmarkbage

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:11 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
justingrantcommented, Sep 14, 2021

I’m seeing the same failures on my Mac, so I’d suggest re-opening this. Versions:

  • node -v v16.5.0
  • yarn -v 1.22.4
  • MacOS: Big Sur 11.5.2 (20G95)
  • React is running latest main branch just rebased a few days ago

LMK how I can help repro this and/or diagnose the root cause. It’s actually a somewhat annoying issue when working on PRs because tests never run green.

0reactions
eps1loncommented, Mar 5, 2022

yarn test ReactART now passes on node 14.17.6 (current .nvmrc), 12.22.10 (12 latest), 14.19.0 (14 latest), 16.14.0 (16 latest) and 17.6.0 (17 latest).

Read more comments on GitHub >

github_iconTop Results From Across the Web

No results found

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found