question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Element attributes be removed silently in frameset tag

See original GitHub issue

Do you want to request a feature or report a bug? bug

What is the current behavior? In some historical reason, i am still using obsolete tag frameset in my project. And when i render my component which includes frameset tag in react, some attributes are ignored, like rows, cols. Could anyone tell me why and how to solve it by no hacking way? Thx.

input

export default class obsoleteElment extends React.Component {

  render() {
    return (
      <html>
      <head>
        <meta httpEquiv="content-type" content="text/html; charset=UTF-8" />
          <title>old page</title>
      </head>
      <frameset id="frame-container" rows='60,*' frameBorder="0" border="0"  cols="180,11,*">
      </frameset>
      </html>
    )
  }
}

output

      <html>
      <head>
        <meta http-equiv="content-type" content="text/html; charset=UTF-8" />
          <title>old page</title>
      </head>
      <frameset id="frame-container" frameBorder="0" border="0">
      </frameset>
      </html>

expect

      <html>
      <head>
        <meta http-equiv="content-type" content="text/html; charset=UTF-8" />
          <title>old page</title>
      </head>
      <frameset id="frame-container" rows='60,*' frameBorder="0" border="0"  cols="180,11,*">
      </frameset>
      </html>

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?

react version image

node environment image image

OS image

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:6 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
Simekcommented, Sep 19, 2018

I dig a little in to this. Currently many other obsolete tags are supported correctly. Also according to documentation all attributes should be supported:

As of React 16, any standard or custom DOM attributes are fully supported.

I’m gonna prepare PR later today which should fix that issue.

0reactions
stale[bot]commented, Jan 19, 2020

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you!

Read more comments on GitHub >

github_iconTop Results From Across the Web

Frames in HTML documents - W3C
The FRAMESET element specifies the layout of the main user window in terms of rectangular subspaces. Rows and columns. Setting the rows attribute...
Read more >
Why Do Some HTML Elements Become Deprecated?
Another common scenario is when technical elements get deprecated as a prelude to their future removal (which we sometimes call “sunsetting” ...
Read more >
<frameset> - HTML: HyperText Markup Language | MDN
This attribute specifies the number and size of vertical spaces in a frameset. Example. <frameset cols="50 ...
Read more >
HTML Standard
Continuing the above example, a requirement stating that a particular attribute's value is constrained to being a valid integer emphatically does not imply ......
Read more >
File: REFERENCE — Haml Documentation
Any string is a valid element name; Haml will automatically generate opening and closing tags for any element. Attributes: {} or (). Brackets...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found