[eslint-plugin-react-hooks] Bug: exhaustive-deps not working with function declaration

When extracting a useEffect callback from inline to a funcion declaration, the exhaustive-deps rule stops showing warnings related to the referenced function

React version: 16.12.0 eslint-plugin-react-hooks version: 1.7.0

Steps To Reproduce

1. Add a basic useEffect code which doesn’t declare one of the dependencies in the array (tmp)

  const [tmp, setTmp] = useState("");

  useEffect(() => {
    console.log(tmp);
  }, []);

1. ESLint shows the exhaustive-deps warning
2. Extract the useEffect callback to a function declaration

  const [tmp, setTmp] = useState("");

  function sideEffect() {
    console.log(tmp);
  }

  useEffect(sideEffect, []);

Link to code example: https://codesandbox.io/s/summer-sunset-oie9s

The current behavior

ESLint plugin does not show the exhaustive-deps warning

The expected behavior

ESLint plugin should work even if the useEffect callback isn’t inline

[gaearon]

oops I meant https://github.com/facebook/react/issues/16573

[yuriybelike]

Sorry for deleting the previous comment, wrong account.

The effects weren’t meant to be reused, the goal was to name them, in order to avoid having to read the impl to understand what they do.

I preffered this approach over custom hooks because the code is coupled to the component and is not really reusable.