Expose createPortal in react-reconciler
See original GitHub issueDo you want to request a feature or report a bug?
Feature
What is the current behavior?
createPortal
is only available in the shared private package with the REACT_PORTAL_TYPE
symbol also in the same shared package
That means that any renderer wishing to allow portals needs to be in the React codebase.
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your code and it doesn’t have dependencies other than React. Paste the link to your JSFiddle (https://jsfiddle.net/Luktwrdm/) or CodeSandbox (https://codesandbox.io/s/new) example below:
N/A
What is the expected behavior?
The possibility of creating portals for custom renderers should be exposed to renderer developers by making it available in react-reconciler
.
Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?
react
16.4.0react-reconciler
0.11.0- Chrome on Windows
- Non-public Reconciler
- Never worked in any React version
I can write the corresponding patch if the maintainers are ok with the change.
Issue Analytics
- State:
- Created 5 years ago
- Comments:7 (7 by maintainers)
Gotta make sure I can first but we can eventually discuss that on Reactiflux or twitter DMs at some point.
That worked perfectly, thanks!
I have to thank you by the way, it’s been a long time since I’ve been able to properly use React and things have clearly evolved in the right direction. Moreover, writing a renderer is not a daunting task either. I managed to get a fully featured React 16.4 in a matter of weeks in a completely different environment than the DOM. Continue the awesome work!