☂️✅ Green CI: Re-enabling disabled tests

We have a handful of tests that have been disabled on Circle CI over the years. It’s time to get these back up and running so we can merge PRs and cut new releases with confidence.

This is an umbrella task intended to track all the work necessary to re-enable these tests. This issue is being kept up to date so new items will be added and completed ones will be (re)moved. Some of the items will spawn separate issues to track work. If you don’t see a name assigned to any of the below items and you would like to help out, please volunteer in the comments and reach out to me to get started!

What needs to be re-enabled?

These tests are configured as aliases in the Circle CI config. I’m happy to help with the Circle CI side of things, but for now you can focus on making sure the command/script (e.g. ./scripts/run-ci-e2e-tests.js --ios) succeeds locally.

Circle CI Job	Test Name	Test Script	Fix?
test_android	Android e2e	node ./scripts/run-ci-e2e-tests.js --android
test_ios	iOS e2e	node ./scripts/run-ci-e2e-tests.js --ios
test_js	JS e2e	node ./scripts/run-ci-e2e-tests.js --js	https://github.com/facebook/react-native/pull/28392
test_ios	Podspecs	./scripts/process-podspecs.sh

[timkuilman]

iOS end-to-end tests

These run as part of the test_ios job, and are disabled by default. To run them, edit .circleci/config.yml and set run_disabled_tests to true under the test_ios workflow at the end of the file (pending #28392 getting merged):

workflows:
  version: 2

  tests:
    jobs:
...
      - test_ios:
          run_disabled_tests: true
          requires:
            - setup_ios

Why it’s failing

react-native $ node ./scripts/run-ci-e2e-tests.js --ios
...
▸ Building Pods/Flipper [Debug]
▸ Check Dependencies
▸ Building Pods/FlipperKit [Debug]
▸ Check Dependencies
▸ Building Pods/Pods-HelloWorld [Debug]
▸ Check Dependencies
▸ Building Pods/Pods-HelloWorld-HelloWorldTests [Debug]
▸ Check Dependencies
▸ Building HelloWorld/HelloWorld [Debug]
▸ Check Dependencies
▸ Running script 'Start Packager'
▸ Linking HelloWorld
⚠️  ld: directory not found for option '-L-L/Users/distiller/Library/Developer/Xcode/DerivedData/HelloWorld-ddyeadlplgsjokalhojpfxozuuyp/Build/Products/Debug-iphonesimulator/CocoaAsyncSocket'

❌  ld: library not found for -lCocoaAsyncSocket



❌  clang: error: linker command failed with exit code 1 (use -v to see invocation)


Testing failed:
	HelloWorld:
		Linker command failed with exit code 1 (use -v to see invocation)
	Testing cancelled because the build failed.

After upgrading a project with version 0.61.2 to 0.62.0 building the app fails with the same error.

[casperboone]

Working on fixing the android e2e tests! Once I’ve made some (more) progress, I’ll give an update 😃