[0.54] BlobModule.addNetworkingHandler mock missing in jest setup

Upgrading react native to 0.54.0 causes the jest tests to fail with an error TypeError: BlobModule.addNetworkingHandler is not a function

Environment:

OS: macOS Sierra 10.12.6 Node: 8.9.1 Yarn: 1.3.2 npm: 5.6.0 Watchman: 4.7.0 Xcode: Xcode 9.0 Build version 9A235 Android Studio: Not Found

Packages: (wanted => installed) react: ^16.3.0-alpha.1 => 16.3.0-alpha.1 react-native: 0.54.0 => 0.54.0

Expected Behavior

The tests should not break on upgrade

Actual Behavior

The test suite fails to run with an error

Steps to Reproduce

• Upgrade react-native to 0.54.0
• Run jest tests

[n-kumari]

@FireNoid I think the change should be made in the jest setup file instead of the file node_modules/react-native/Libraries/Blob/BlobManager.js itself.

The setup file is where we should mock the required modules. So, in node_modules/react-native/jest/setup.js

Change

BlobModule: {
    BLOB_URI_SCHEME: 'content',
    BLOB_URI_HOST: null,
    enableBlobSupport: jest.fn(),
    disableBlobSupport: jest.fn(),
    createFromParts: jest.fn(),
    sendBlob: jest.fn(),
    release: jest.fn(),
  },

to

BlobModule: {
    BLOB_URI_SCHEME: 'content',
    BLOB_URI_HOST: null,
    addNetworkingHandler: jest.fn(),
    enableBlobSupport: jest.fn(),
    disableBlobSupport: jest.fn(),
    createFromParts: jest.fn(),
    sendBlob: jest.fn(),
    release: jest.fn(),
  }

[n-kumari]

@hramos BlobModule .addNetworkingHandler is being used in Libraries/Network/XMLHttpRequest.js but probably does not have a test coverage around it. Our test suites are designed differently than the ones being used by react-native, so not sure which test suite it is.

Here is the what the failure says

Let me know if this helps.