question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

0.54.0 cherry-pick issue has been locked, preventing community from helping maintain

See original GitHub issue

My company uses React Native for our mobile app and has been working to give back to the React Native community by identifying fixes and adopting the latest version of React Native to help identify issues in the latest releases.

Last week, we identified a regression in the <Text> component, and found that an issue had already been filed for it: #18258. Not only that, but @shergin had also identified a fix, and committed it to master: https://github.com/facebook/react-native/commit/a534672e132136e7bbd17c94a7f4e67149bcc67a

It’s my understanding that these issues should be used to track what cherry-picks should happen to fix bugs in each release. In fact, I’ve been instructed by maintainers to advocate for cherry-picks in the past before.

However, upon proposing that a commit be cherry-picked into the latest release this time, the issue was promptly closed. I was left feeling like my feedback was not wanted, even though I had spent the time to thoroughly investigate the issue, and bring a well-formulated issue to light. I understand that React Native receives a lot of poorly-formulated issues that do not provide enough information for the maintainers of this repo to act upon, yet I feel that my comment was warranted as it clearly identified a fix.

Is this not the appropriate process to sifting through the sea of GitHub issues and identifying fixes, to help better maintain this project? If not, what is the right way to help maintain React Native, as a well-intentioned user of the framework?

Thanks for listening.

Steps to Reproduce

  1. Find a regression in a React Native release
  2. Identify a fix has landed in the next release
  3. Identify that the fix would be backwards compatible with current release that has the regression
  4. Propose that the fix gets cherry-picked into the current release to fix the regression

Expected Behavior

The fix gets cherry-picked by a maintainer in the latest release to fix the regression.

Actual Behavior

Issue to keep track of cherry-pick proposals is marked as “off-topic” and is locked by a maintainer. https://github.com/facebook/react-native/issues/18128#event-1532061585 screen shot 2018-03-21 at 9 47 03 am

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

2reactions
hramoscommented, Mar 21, 2018

Yes. @grabbou coordinates releases and was the original advocate for tracking cherry-pick requests in issues in this repo. He has now created a new repo, react-native-releases, specifically for this purpose. Going forward, use that repo for cherry-pick requests. There should be an issue for each upcoming release. This will help keep the core repo clear of non-bug report issues.

1reaction
eliperkinscommented, Mar 21, 2018

@hramos so should we propose cherry-picks to that issue instead? That’s still unclear to me…

Read more comments on GitHub >

github_iconTop Results From Across the Web

git-cherry-pick Documentation - Git
Usually you cannot cherry-pick a merge because you do not know which side of the merge should be considered the mainline. This option...
Read more >
Release Notes — Numba 0.56.4+0.g288a38bbd.dirty-py3.7 ...
This is a bugfix release to fix a regression in the CUDA target in relation to the .view() method on CUDA device arrays...
Read more >
CHANGELOG.md · v12.5.7 · GitLab.org / GitLab FOSS
Changed (56 changes, 6 of them are from the community). Upgrade design/copy for issue weights locked feature. !17352; Reduce new MR page ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found