[Android] Using a different package name to build fails to use the correct manifest file

As a follow-up to #12820, filing a new issue about RN not using the correct manifest file.

Per @pcguru 's comment:

Whenever one of your flavors has a different package name #13169 still fails as it will use the packageName from the wrong AndroidManifest.xml. That is, it will not use the AndroidManifest.xml that was generated during build.

Currently, I’m able to use adb install to directly install the apk to a device to get around this issue.

Is this a bug report?

No

Have you read the Contributing Guidelines?

Yes

Environment

Environment: OS: macOS Sierra 10.12.6 Node: 8.2.0 Yarn: Not Found npm: 5.3.0 Watchman: 4.7.0 Xcode: Xcode 9.0 Build version 9A235 Android Studio: 3.0 AI-171.4443003

Packages: (wanted => installed) react: ^16.0.0 => 16.0.0 react-native: ^0.51.0 => 0.51.0

Discussions have already happened in #5546, #13169, and #12820. @hramos please review this and advise what to do next.

[Nandez89]

I’m having the same issue app builds and installs but it won’t open on the emulator because the package name is missing the applicationIdSuffix ‘.dev’ added on buildTypes

my applicationId ‘ca.myapp.ori’

BUILD SUCCESSFUL

Total time: 2 mins 0.982 secs

Running /Users/user/Library/Android/sdk/platform-tools/adb -s emulator-5554 reverse tcp:8081 tcp:8081
Starting the app on emulator-5554 (/Users/user/Library/Android/sdk/platform-tools/adb -s emulator-5554 shell am start -n ca.myapp.ori/ca.myapp.ori.MainActivity)...
Starting: Intent
Error type 3
Error: Activity class {ca.myapp.ori/ca.myapp.ori.MainActivity} does not exist.

Any help in how to fix this or work around it. I definitely need to keep the buildTypes

[salmanwaheed]

This message was created automatically by mail delivery software.

A message that you sent could not be delivered to one or more of its recipients. This is a temporary error. The following address(es) deferred:

[e-mail] Domain salmanwaheed.info has exceeded the max emails per hour (174/150 (115%)) allowed. Message will be reattempted later

------- This is a copy of the message, including all the headers. ------ Received: from github-smtp2-ext4.iad.github.net ([192.30.252.195]:39522 helo=github-smtp2a-ext-cp1-prd.iad.github.net) by box1177.bluehost.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from [e-mail]) id 1epQVb-003JRI-Or for [e-mail]; Fri, 23 Feb 2018 20:28:24 -0700 Date: Fri, 23 Feb 2018 19:22:07 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1519442868; bh=1nVgloGWsCrDpcsfKp5V7Nl6k6YCO1iIG20vIOuW6gc=; h=From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=bXE7tZbPiSfRVC/Gzwcjkf+xbfXJbaeBo3gWlEXIXm6HGiV9yIr+LRkbpVR2VvmWu sT+j9cQHfJOQRsO+H+E8XmkDJThhxTicIjl151QlctHt8FmQP43XfDy6vYj56t+OLS fF4eDrurbRwaxBUJpe8ApvFMmLPRgwfgaR5vCq0w= From: React Native Bot [e-mail] Reply-To: facebook/react-native [e-mail] To: facebook/react-native [e-mail] Cc: Subscribed [e-mail] Message-ID: facebook/react-native/issues/17615/[e-mail] In-Reply-To: facebook/react-native/issues/[e-mail] References: facebook/react-native/issues/[e-mail] Subject: Re: [facebook/react-native] [Android] Using a different package name to build fails to use the correct manifest file (#17615) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=“–==_mimepart_5a90da5f82e89_1055d3fe901128f34299329”; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: react-native-bot X-GitHub-Recipient: salmanwaheed X-GitHub-Reason: subscribed List-ID: facebook/react-native <react-native.facebook.github.com> List-Archive: https://github.com/facebook/react-native List-Post: mailto:[e-mail] List-Unsubscribe: mailto:unsub+00ef1b3817fc79c16d23[e-mail], https://github.com/notifications/unsubscribe/AO8bOGw0EBCdJ4Y021c59OwsObx9urOFks5tX4BfgaJpZM4Rexed X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: [e-mail] X-Spam-Status: No, score=-1.0 X-Spam-Score: -9 X-Spam-Bar: - X-Ham-Report: Spam detection software, running on the system “box1177.bluehost.com”, has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see root@localhost for details.

Content preview: Thanks for posting this! It looks like you may not be using the latest version of React Native, v0.53.0, released on January 2018. Can you make sure this issue can still be reproduced in the latest version? […]

Content analysis details: (-1.0 points, 5.0 required)

pts rule name description

---

0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: github.io] -0.5 SPF_PASS SPF: sender matches SPF record 0.0 HTML_IMAGE_ONLY_32 BODY: HTML: images with 2800-3200 bytes of words 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author’s domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.4 AWL AWL: Adjusted score from AWL reputation of From: address X-Spam-Flag: NO

----==_mimepart_5a90da5f82e89_1055d3fe901128f34299329 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Thanks for posting this! It looks like you may not be using the latest ve= rsion of React Native, v0.53.0, released on January 2018. Can you make su= re this issue can still be reproduced in the latest version? =

I am going to close this, but please feel free to open a new issue if you= are able to confirm that this is still a problem in v0.53.0 or newer.

_{[How to Contribute](https://facebook.github.io/react-native/docs/con= tributing.html#bugs) =E2=80=A2 [What to Expect from Maintainers](https://= facebook.github.io/react-native/docs/maintainers.html#handling-issues)</s= ub>}

– =

You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/facebook/react-native/issues/17615#issuecomment-368194= 868=

----==_mimepart_5a90da5f82e89_1055d3fe901128f34299329 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Thanks for posting this! It looks like you may not be using the latest= version of React Native, v0.53.0, released on January 2018. Can you make= sure this issue can still be reproduced in the latest version?

I am going to close this, but please feel free to open a new issue if = you are able to confirm that this is still a problem in v0.53.0 or newer.=

_{How to Contribute =E2=80=A2 What to Expect from Maintainers}

&m= dash;
You are receiving this because you are subscribed to this thre= ad.
Reply to this email directly, view it on GitHub<= /a>, or mute the thread.<im= g alt=3D"" height=3D"1" src=3D"https://github.com/notifications/beacon/AO= 8bOHUxiNlNvk4C2o2bg0BLyZAR4HeYks5tX4BfgaJpZM4Rexed.gif" width=3D"1" /></p= > <div itemscope itemtype=3D"http://schema.org/EmailMessage"> <div itemprop=3D"action" itemscope itemtype=3D"http://schema.org/ViewActi= on"> <link itemprop=3D"url" href=3D"https://github.com/facebook/react-native= /issues/17615#issuecomment-368194868"></link> <meta itemprop=3D"name" content=3D"View Issue"></meta> </div> <meta itemprop=3D"description" content=3D"View this Issue on GitHub"></me= ta> </div> <script type=3D"application/json" data-scope=3D"inboxmarkup">{"api_versio= n":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name"= :"GitHub"},"entity":{"external_key":"github/facebook/react-native","title= ":"facebook/react-native","subtitle":"GitHub repository","main_image_url"= :"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d8= 8-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubuse= rcontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.= png","action":{"name":"Open in GitHub","url":"https://github.com/facebook= /react-native"}},"updates":{"snippets":[{"icon":"PERSON","message":"@reac= t-native-bot in #17615: Thanks for posting this! It looks like you may no= t be using the latest version of React Native, v0.53.0, released on Janua= ry 2018. Can you make sure this issue can still be reproduced in the late= st version? \n\nI am going to close this, but please feel free to open a = new issue if you are able to confirm that this is still a problem in v0.5= 3.0 or newer.\n\n\u003csub\u003e[How to Contribute](https://facebook.gith= ub.io/react-native/docs/contributing.html#bugs) =E2=80=A2 [What to Expect= from Maintainers](https://facebook.github.io/react-native/docs/maintaine= rs.html#handling-issues)\u003c/sub\u003e\n\n"}],"action":{"name":"View Is= sue","url":"https://github.com/facebook/react-native/issues/17615#issueco= mment-368194868"}}}</script>=

----==_mimepart_5a90da5f82e89_1055d3fe901128f34299329–